Fix container version mismatch by moving build type ARG after FROM #473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From the log https://github.com/vllm-project/guidellm/actions/runs/18408284407/job/52453702204#step:5:468 , it can be seen that
GUIDELLM_BUILD_TYPE=$GUIDELLM_BUILD_TYPEin the container file was not correctly assigned. The reason is that theARGinstructions defined beforeFROMare global but not available in the build stage context, which can lead to improper version tagging during the build process. This caused the container to use an incorrect version string. Ref to https://docs.docker.com/reference/dockerfile#understand-how-arg-and-from-interactDetails
Moved the
ARG GUIDELLM_BUILD_TYPE=devinstruction and its explanatory comments after theFROM $BASE_IMAGE as builderstatement. This ensures the build type argument is properly scoped to the build stage.Test Plan
buildah build --build-arg GUIDELLM_BUILD_TYPE=release, then check if the logs return the correct version.Related Issues
Use of AI
## WRITTEN BY AI ##)